feat: add customMethodNames to PaymentSheet configuration#93
Open
ArushKapoorJuspay wants to merge 1 commit into
Open
feat: add customMethodNames to PaymentSheet configuration#93ArushKapoorJuspay wants to merge 1 commit into
ArushKapoorJuspay wants to merge 1 commit into
Conversation
13 tasks
659def4 to
745466c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Adds
customMethodNamessupport toPaymentSheet.Configurationon Android so merchants can override the display label of TAB-type payment methods.This is part of the mobile
customMethodNamesfeature port from hyperswitch-web. One intentional difference from hyperswitch-web is scope: in web, the currentcustomMethodNameshelper is effectively gated by aclassic/evouchercheck inPaymentUtils.getDisplayNameAndIcon(), so aliasing is not applied as a general-purpose rename path for all payment methods. In hyperswitch-client-core, this was implemented as a scalable tab-label override for any TAB-type payment method.The Android implementation serializes the configuration value through the native bundle as a JSON string because the client-core ReScript layer receives Android configuration through the React Native bridge.
Included changes:
PaymentMethodAliascustomMethodNames: List<PaymentMethodAlias>?toPaymentSheet.ConfigurationHow did you test it?
hyperswitch-client-coreReScript layer compiles withnpm run re:checkImpact on Mobile and Web Repositories
Checklist